Added documentation for constraint message parameters #10617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added missing documentation of charsetMessage in the Length constraint
javiereguiluz
added
Missing Documentation
Form
Status: Reviewed
and removed
Status: Needs Review
labels
|
Timo, thanks a lot for working on this. I reckon this must have been a boring and time-consuming task ... so we deeply appreciate your contribution! Thank you!! |
javiereguiluz
added a commit
that referenced
this pull request
Oct 31, 2018
…imoBakx) This PR was merged into the 2.8 branch. Discussion ---------- Added documentation for constraint message parameters After #10584, I checked the documentation for the other constraints and updated the possible parameters in messages. I also added missing documentation for `charsetMessage` in the Length constraint. Commits ------- ed3d366 Added documentation for message parameters
|
This has been merged in all upper branches. While merging I realized that these new messages from |
|
Yeah, those were on my list to pick up after the merge. ;-) |
javiereguiluz
added a commit
that referenced
this pull request
Oct 31, 2018
…dded between 2.8 and 3.4 (TimoBakx) This PR was merged into the 3.4 branch. Discussion ---------- [Validator] Added documentation for message parameters added between 2.8 and 3.4 in the validator image constraint reference. These were omitted in #10617 as it targeted 2.8. Commits ------- 0c76057 Added documentation for message parameters added between 2.8 and 3.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #10584, I checked the documentation for the other constraints and updated the possible parameters in messages.
I also added missing documentation for
charsetMessagein the Length constraint.